Fix constrained call corner cases #111178
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet/runtimelab#1431. Fixes dotnet#98582. Fixes dotnet#98581.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- src/tests/issues.targets: Language not supported
- src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/GenericDictionaryCell.cs: Evaluated as low risk
- src/coreclr/tools/Common/Compiler/TypeExtensions.cs: Evaluated as low risk
- src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs: Evaluated as low risk
- src/coreclr/tools/Common/TypeSystem/Common/MetadataVirtualMethodAlgorithm.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/NativeLayoutVertexNode.cs:1835
- Ensure that the new cases for GenericInstanceConstrainedMethod and NonGenericInstanceConstrainedMethod are covered by tests.
return (_constrainedMethod.HasInstantiation, _constrainedMethod.Signature.IsStatic) switch
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/GenericLookupResult.cs:866
- Ensure that the new behavior for resolving non-static constrained methods is covered by tests.
implMethod = instantiatedConstraintType.GetClosestDefType().ResolveVariantInterfaceMethodToVirtualMethodOnType(instantiatedConstrainedMethod);
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Jan 9, 2025
The problem was always `// Note: We don't set the IsUnboxingStub flag on template methods (all template lookups performed at runtime are performed with this flag not set`, I tried working around it in the original fix, but looks like I actually need the function pointer in dotnet#111178 (the tests are not failing but I have a local test that does). So trying an alternative approach that just deletes the weird code. It's possible this only had to be weird due to universal shared code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtimelab#1431.
Fixes #98582.
Fixes #98581.