fix: Generalise re_replacement_seq to deal with all cases #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torymur
reviewed
Jan 8, 2025
torymur
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #90, and generalises the regex to deal with all the previous, and hopefully all future cases as well.
The new special case not covered by the previous approach are the
�?and�,tokens, used by Salamandra models. Since all these special tokens (new and old) consist of one or more � symbols, with an optional single-character prefix and/or suffix, we can simplify and generalise the pattern to r"^.?�+.?$".Tagging @torymur here, since you reviewed the previous PR.