Use outlines-core to translate JSON Schemas into regexes
#1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
use-outlines-core-json-schema
branch
4 times, most recently
from
088e42d to
9aca8c7
Compare
rlouf
force-pushed
the
use-outlines-core-json-schema
branch
from
9aca8c7 to
9d67934
Compare
The `enum` keyword is reserved for arrays of constants. When we have callables as members of a Python `Enum`, we get an object whose properties are the arguments of the callable. The `Enum` thus needs to be converted into a `oneOf` field.
|
Coverage will necessarily fail, they correspond to the MLX array conversion and we cannot test MLX on GH runners. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlines is currently using its own logic to translate JSON Schema definitions into regular expressions. However, this logic was ported to
outlines-corerecently. In this PR I remove Outlines' implementation and importoutlines-core's instead.TODO
It seems likeThat's completely expected sinceoutlines-coredoes not support theenumkeyword when the elements are objects. Craft a MRE and open an issue there.enumis for constant values only. I fixed this by convertingenumintooneOf.