fix: use "cli" as client id when logging in, fixes #182 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the official bitwarden cli uses the following parameters when logging in (POST /connect/token): ``` scope=api offline_access client_id=cli deviceType=25 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=linux grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` before this commit, rbw uses these parameters: ``` scope=api offline_access client_id=desktop deviceType=8 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=rbw devicePushToken= grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` although there are multiple differences, changing the client id from "desktop" to "cli" is sufficient to fix the issue.
|
I have also created a branch that shows how to export the tls keys from rbw to debug the network requests in wireshark, see https://github.com/impact-merlinmarek/rbw/tree/enable-sslkeylogfile |
|
thanks! |
|
As for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the official bitwarden cli uses the following parameters when logging in (POST /connect/token):
before this commit, rbw uses these parameters:
although there are multiple differences, changing the client id from "desktop" to "cli" is sufficient to fix the issue.