Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rbw code: totp secret was not valid base32 #189

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

illfygli
Copy link
Contributor

After a recent update, most of my TOTP secrets stopped working, with the message:

rbw code: totp secret was not valid base32

I found that it's because they must be uppercase now.

This patch makes the secret uppercase, before decoding, which resolves the issue for me.

@adamthiede
Copy link

I encountered this issue as well and this has fixed it, thank you. How did you figure this out?

@illfygli
Copy link
Contributor Author

illfygli commented Jun 27, 2024

@adamthiede I cloned the repo, so I could look around with better tools.
It looked like the TOTP code only accepted uppercase letters, so I tried uppercasing a broken TOTP, and that fixed it, so I made the code do that.

I tried to find out why/when it broke, but I don't really know Rust, and it seemed like a simple-enough fix, so I put up the PR and let those who do know it be the judge. :)

@doy doy merged commit 4056f9a into doy:main Jul 3, 2024
8 checks passed
@rjc
Copy link

rjc commented Jul 3, 2024

I've also encountered it and, after not being able to find it under issues, I reported it yesterday - #191 ;^)

I hadn't tried the patch yet but, it seems like it only fixes one of the issues mentioned in there, so I'll leave it open until the padding issue is also fixed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants