Opamroot redirect #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
changed the base branch from
revised-windows-init
to
opamroot-redirect-base
rjbou
reviewed
Jun 10, 2024
src/client/opamClient.ml
Outdated
Comment on lines
1678
to
1680
| let collision = | ||
| (* UTF-8 <U+0020, U+1F4A5> (Collision emoji) *) | ||
| if OpamConsole.color () then " \xF0\x9F\x92\xA5" else "" |
There was a problem hiding this comment.
(also verified that that means the running opam init in conhost correctly doesn't display anything)
rjbou
reviewed
Jun 10, 2024
| "\n\ | ||
| %s\n\ | ||
| \n\ | ||
| Many parts of the OCaml ecosystem do not presently work correctly\n\ |
There was a problem hiding this comment.
I see where you're coming from, but we do already have "opam and the OCaml ecosystem in general require various Unix tools" in the previous messages?
dra27
force-pushed
the
opamroot-redirect-base
branch
from
c317e22 to
6730dea
Compare
Used to indicate opam root redirection
It is needed for Cygwin installation, that doesn't handle paths with space. At init, detection and redirection are done, afterwards opam always load redirected opam root. Original root directory is stored in `OpamStateConfig.!r.original_root_dir`. Co-authored-by: David Allsopp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.