Add flag for IBM Cloud Sysdig and update the team management for IBM. #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found there are some different sysdig API response (i.e. the user email, dashboards ) in IBM sysdig and draios version.
For example:
/api/users
In IBM sysdig, the
username
in the API response is not the user email address but the value generated by IBM./api/teams
In IBM sysdig , there are no
userRoles
in the response but just the"userCount":
:/api/v2/dashboards
In both IBM sysdig and draios version, there are no
isShared
value butshared
, also noannotations
values.create_dashboard_from_view
is not correct inkube_obj_parser.py
.sysdig-kube-watcher/kube_obj_parser.py
Line 342 in 068e659
The correct function is here and last argument is boolean type.
"def create_dashboard_from_view(self, newdashname, viewname, filter, shared=False, public=False):"
https://github.com/draios/python-sdc-client/blob/9b6a7fba636dbf0a73d65b59ceec4d7f16af97bc/sdcclient/_monitor.py#L645