Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix battery spamming on Tuya smart button IH-663 #7509

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Jan 2, 2024

See #7205

This PR just remove the device from his original DDF to put it in a DDF for another smart button that use the tuya unlock feature.

@Smanar Smanar mentioned this pull request Jan 2, 2024
Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important detail to consider 😉

devices/tuya/_TZ3000_ja5osu5g_smart_button.json Outdated Show resolved Hide resolved
@SwoopX SwoopX added the Fix label Jan 6, 2024
@Smanar Smanar requested a review from SwoopX January 7, 2024 08:58
Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manup
Copy link
Member

manup commented Jan 31, 2024

PR looks fine to me, but GIT reports merge conflict.
@Smanar can you please have a look

@Smanar
Copy link
Collaborator Author

Smanar commented Jan 31, 2024

Done.

@manup manup changed the title FIX, prevent battery spamming on Tuya smart button IH-663 Fix battery spamming on Tuya smart button IH-663 Feb 3, 2024
@manup manup added this to the v2.25.2 milestone Feb 3, 2024
@manup manup merged commit 9c99c22 into dresden-elektronik:master Feb 3, 2024
1 check passed
@Smanar Smanar deleted the tuya_34 branch April 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants