Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tap to close in the input dialog #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable tap to close in the input dialog #22

wants to merge 1 commit into from

Conversation

zhongweiy
Copy link

Besides clicking "Cancel" button, tapping area off InputDialog window also closes this dialog.

Refer InputDialog:onCloseDialog() and InputDialog:onTap() for details.

@zhongweiy
Enable tap to close in the input dialog
530adfc 
Besides clicking "Cancel" button, tapping area off InputDialog window also closes this dialog.

Refer InputDialog:onCloseDialog() and InputDialog:onTap() for details.
miaachan
miaachan reviewed Jan 11, 2025
View reviewed changes
Copy link

@miaachan miaachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cancel button is on the left, while the close button on the bottom right corner of the GPT viewer requires a big reach. Allowing taps outside the dialog to close would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaachan miaachan miaachan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhongweiy @miaachan