Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sliced downloads in GSClient (#389) #391

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Dec 29, 2023

Local PR for live tests


  • feat: Implement sliced downloads in GSClient

  • fix: remove unintended import changes

  • Mock transfer_manager. Test both worker types.

* feat: Implement sliced downloads in GSClient

* fix: remove unintended import changes

* Mock transfer_manager. Test both worker types.
Copy link
Contributor

github-actions bot commented Dec 29, 2023

@github-actions github-actions bot temporarily deployed to pull request December 29, 2023 17:36 Inactive
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bce0f9) 93.7% compared to head (808fd42) 93.7%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #391   +/-   ##
======================================
  Coverage    93.7%   93.7%           
======================================
  Files          22      22           
  Lines        1566    1570    +4     
======================================
+ Hits         1468    1472    +4     
  Misses         98      98           
Files Coverage Δ
cloudpathlib/gs/gsclient.py 94.6% <100.0%> (+0.1%) ⬆️

@github-actions github-actions bot temporarily deployed to pull request December 29, 2023 18:36 Inactive
@pjbull pjbull changed the title WIP: Implement sliced downloads in GSClient (#389) Implement sliced downloads in GSClient (#389) Dec 29, 2023
@pjbull pjbull merged commit 9936a10 into master Dec 29, 2023
28 checks passed
@pjbull pjbull deleted the 389-live-tests branch December 29, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants