OP-SQLite support #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winghouchan
reviewed
Dec 20, 2024
|
Could you ensure your code style follows the existing code style please? Notable differences I can see are:
|
slvssb
force-pushed
the
slvssb/op-sqlite-support
branch
from
0725a51 to
046bcb1
Compare
slvssb
force-pushed
the
slvssb/op-sqlite-support
branch
from
046bcb1 to
4a5e7b4
Compare
|
@slvssb: Sorry, I'm not actually part of Drizzle so can't approve this for you. The comments I left were because I'm also interested in OP SQLite support so I had feedback when reviewing the changes you're proposing. Thanks for the changes though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for OP-SQLite. It introduces a major breaking change and I don't know what would be next version to bump to. Need a help there.
Happy to make changes as needed.
closes #3