This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Adding volume host path type to spec. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Maybe this should also be part of the default runtime, already looks pretty good. |
stevecrozz
pushed a commit
to stevecrozz/drone-runtime
that referenced
this pull request
Jun 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing all valid volume host path types(https://kubernetes.io/docs/concepts/storage/volumes/#hostpath)
By default the
DirectoryOrCreatetype was being used when mounting a host volume, which was causing some pipelines which rely on thedocker.sockbeing available inside the step pod container to fail with:MountVolume.SetUp failed for volume "c18m372vorpojl4s9aj0kz2vaqrvxbmi" : hostPath type check failed: /var/run/docker.sock is not a directory