Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hungrated
reviewed
Oct 15, 2021
| <div id="root"></div> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
在编辑器安装 prettiter 相关插件，并设置保存时自动格式化，避免这种问题
Hungrated
reviewed
Oct 15, 2021
| height: 100%; | ||
| min-height: 100vh; | ||
|
|
||
|
|
Hungrated
reviewed
Oct 15, 2021
| return ( | ||
| <div className={styles.App}> | ||
| <Menu /> | ||
| {/* <Route path={`/home`} component={Home} /> |
Hungrated
reviewed
Oct 15, 2021
| margin-left: -1px; | ||
| margin-top: -1px; | ||
| cursor: pointer; | ||
| // padding: 20px 12px; |
Hungrated
reviewed
Oct 15, 2021
| export default function ComplexSelect() { | ||
|
|
||
| const { selectedList, setSelectedList, | ||
| overallData, setOverallData |
|
收到
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: Zihang Zhang ***@***.***>
发送时间: 2021年10月15日 16:08
收件人: dt-fe/dt-fe-training ***@***.***>
抄送: asterism-q ***@***.***>, Author ***@***.***>
主题: 回复：[dt-fe/dt-fe-training] 秦丹一项目提交 (#3)
@Hungrated commented on this pull request.
In 秦丹一/data-analysis/src/components/ComplexSelect/index.tsx:
> @@ -0,0 +1,64 @@ +import React, { useState, useContext } from 'react' +// import { getOverall } from '../../service'; +import styles from './index.module.scss'; +import up from '../../images/up.svg' +import down from '../../images/down.svg' +import { percentFormat, numberFormat, handleSelect } from '../../utils' +import { OverallContext } from '../../pages/Home/index' + + +export default function ComplexSelect() { + + const { selectedList, setSelectedList, + overallData, setOverallData
代码格式化一下
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Hungrated
reviewed
Oct 15, 2021
| import { OverallContext } from '../../pages/Home/index' | ||
|
|
||
|
|
||
| export default function ComplexSelect() { |
There was a problem hiding this comment.
一般来说，组件声明应规范化，比如加上强类型
const Component: React.FC<Props> = React.memo((props: Props) => {
return xxx;
})
Hungrated
reviewed
Oct 15, 2021
| return ( | ||
| <div className={`${styles.selection} ${overallData.length === 0 ? '' : styles.loading_hidden}`}> | ||
| { | ||
| overallData.map((item) => { |
Hungrated
reviewed
Oct 15, 2021
| return ( | ||
| <div className={styles.datebar}> | ||
| <RangePicker | ||
| format='YYYY-MM-DD' |
Hungrated
reviewed
Oct 15, 2021
| bordered={false} | ||
| allowClear={false} | ||
| inputReadOnly={true} | ||
| suffixIcon={<span></span>} |
Hungrated
reviewed
Oct 15, 2021
|
|
||
| useEffect(() => { | ||
| getCategoryData(time).then(res => { | ||
| setCategoryData(res.data) |
Hungrated
reviewed
Oct 15, 2021
|
|
||
| function choosePage(page: number) { | ||
| setPageFlag(page) | ||
| console.log(page); |
Hungrated
reviewed
Oct 15, 2021
| }, [freshCount, time]) | ||
|
|
||
|
|
||
| function handleChangePage(move: number) { |
Hungrated
reviewed
Oct 15, 2021
| <span>操作</span> | ||
| </div> | ||
| { | ||
| categoryData.slice(pageFlag * 10, pageFlag * 10 + maxOfpage - 1).map((item, index) => { |
There was a problem hiding this comment.
pageFlag * 10 及 pageFlag * 10 + maxOfpage - 1 等，建议在组件头部声明语义化的变量
slice 的结果也可以语义化声明出来，增加代码可读性
Hungrated
reviewed
Oct 15, 2021
| <span className={styles.order}> | ||
| { | ||
| { | ||
| 0: ( |
Hungrated
reviewed
Oct 15, 2021
| onClick={handleChangePage.bind(null, 1)} | ||
| > | ||
| 下一页 | ||
| <img src={require('../../images/nextpage.svg').default} /> |
Hungrated
reviewed
Oct 15, 2021
| const [searchKey, setSearchKey] = useState('') | ||
|
|
||
|
|
||
| useEffect(() => { |
Hungrated
reviewed
Oct 15, 2021
| }, [selectedGoodsList]) | ||
|
|
||
| useEffect(() => { | ||
| if (!renderList.length) { |
There was a problem hiding this comment.
数组判空，使用 lodash
_.isEmpty(renderList)
Hungrated
reviewed
Oct 15, 2021
| useEffect(() => { | ||
| if (!renderList.length) { | ||
| let lenghthSum = 0 | ||
| for (const item of selectedGoodsList) { |
There was a problem hiding this comment.
数组迭代逻辑一般无需使用 for 循环。
推荐使用 ES6 的 Array.prototype.map 和 Array.prototype.reduce；其他API也可以了解下，如 filter some every forEach等 都比较常用
https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Array/map
Hungrated
reviewed
Oct 15, 2021
| function handleDeleteInput(event: any) { | ||
| const { keyCode } = event | ||
| //判断按下的是不是删除 | ||
| if (keyCode !== 8) return |
Hungrated
reviewed
Oct 15, 2021
| const { keyCode } = event | ||
| //判断按下的是不是删除 | ||
| if (keyCode !== 8) return | ||
| selectedGoodsList.pop() |
There was a problem hiding this comment.
pop 方法会改变 selectedGoodsList 本身，不符合 React 数据流中的 immutable 原则；
这里可以直接根据需求在下一行 slice(0, _.size(selectedGoodsList)-1) 去掉最后一个，或 slice(1) 去掉第一个
Hungrated
reviewed
Oct 15, 2021
| function searchInput(e: any) { | ||
| if (e.keyCode !== 13) return | ||
| setSearchKey(e.target.value) | ||
| console.log(e.target.value); |
Hungrated
reviewed
Oct 15, 2021
| }) | ||
| } | ||
| { | ||
| renderList.length === selectedGoodsList.length |
Hungrated
reviewed
Oct 15, 2021
| export default function SideMenu() { | ||
| const [selectedKey, setSelectedKey] = useState(sideMenuList[0].key) | ||
| window.addEventListener('scroll', () => { | ||
| var scrollTop = document.documentElement.scrollTop || document.body.scrollTop; |
Hungrated
reviewed
Oct 15, 2021
| } | ||
|
|
||
| export async function getName() { | ||
| const url = `http://120.26.194.171:3000/v1/trade/overall`; |
There was a problem hiding this comment.
const baseUrl = 'http://120.26.194.171:3000/v1';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.