Dunify version v1.9.6 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anil Madhavapeddy <[email protected]>
This will let the `findlib.dynload` package work correctly with dune, which has special handling for it. @diml says: > dune generates a small module that is linked just after it and registers the libraries that are statically linked in so that at > runtime findlib.dynload doesn't dynamically load them again
this lets `findlib` work in a duniverse, which it doesnt when only added as a META template
`findlib_config.ml` is entirely generated by the `discover` tool which doesn't use that template anymore.
Remove default config so findlib can be used in a duniverse
Findlib is supposed to load lazily but linking with Topfind made it load immediately. Which made findlib looks for its config file and eventually crash before the user had a change to call Findlib.init_manually
Avoid eager self-init
Revised dune port
|
It's still necessary to install the META files for the compiler if ocaml < 5. Probably there's already some logic in findlib that does this. You can replicate that in the dune config (note that for this to work on ocaml >= 5, it also requires dune >= 3.4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to update merge the changes from dune-universe-1.9.5 with the upstream 1.9.6 release. The good thing is that upstream now features some of the changes we had made, so I could drop some patches.
I am however unclear on the
METAfiles that we install, if I understand the changes in 1.9.6 correctly we should not be doing this on OCaml releases 5.0+ anymore. Am I right in this assumption?