Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer support #202

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add devcontainer support #202

merged 2 commits into from
Dec 8, 2023

Conversation

alexsapps
Copy link
Collaborator

No description provided.

@alexsapps alexsapps requested a review from jakehobbs December 4, 2023 21:25
Copy link
Contributor

@mdempsky mdempsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions.

"customizations": {
"vscode": {
"extensions": [
"ms-vscode.makefile-tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other extensions to add? Maybe Go and Vue?

}

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forward the ADB port?

@alexsapps alexsapps merged commit 77dcbc6 into master Dec 8, 2023
1 check passed
@alexsapps alexsapps deleted the alex/devcontainer branch December 8, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants