Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Go files into src directory #22

Closed
wants to merge 3 commits into from
Closed

Move Go files into src directory #22

wants to merge 3 commits into from

Conversation

AlexisDeschamps
Copy link
Contributor

@AlexisDeschamps AlexisDeschamps commented Aug 30, 2021

Issue: #16

Testing

See that the output is as expected for:
Run make dev
Run make test

@AlexisDeschamps
Copy link
Contributor Author

@jakehobbs It loos like this works out of the box. Do you know if there is an expected way it could break?

Copy link
Member

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev Dockerfile also needs to be updated with new path: go build -o alc-mobile-api ./src, then I think this should be fine.

I think the problem I was running into before was just that I was also trying to move the templates, static, and model directories into src. But maybe that is not something we want to do.

@AlexisDeschamps
Copy link
Contributor Author

@jakehobbs Cool, thanks. I tried to also do that and made some other updates Does Dockerfile-prod not also need to be changed?

Tests I ran:

  • make dev: output looked the same as the main branch
  • make test: output looked the same as the main branch
  • docker build -f Dockerfile -t dev-test .: output is stderr: 2021/09/13 00:26:13 missing configuration for DB_DSN so it seems to work
  • docker build -f Dockerfile-prod -t prod-test .: output is stderr: 2021/09/13 00:26:13 missing configuration for DB_DSN so it seems to work

@jakehobbs
Copy link
Member

Everything seems to be working for me locally with a full config. Do we want the model directory to be inside of the main directory though? It feels a bit weird to me, but I'm not sure what the standard practice is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants