Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old interfaces, types and entities #579

Merged
merged 5 commits into from
Apr 15, 2023
Merged

Remove old interfaces, types and entities #579

merged 5 commits into from
Apr 15, 2023

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Apr 14, 2023 •
edited
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (changes that require a fresh clone of the repo)
  • I'm not sure

@ZibanPirate ZibanPirate self-assigned this Apr 14, 2023
@ZibanPirate ZibanPirate linked an issue Apr 14, 2023 that may be closed by this pull request
remove old interfaces/types/entities #578
Closed
@github-actions github-actions bot added api API related changes ( api folder ) data Data related changes ( data folder ) tooling tooling package ui ui package web Web related changes ( web folder ) labels Apr 14, 2023
@ZibanPirate ZibanPirate changed the base branch from main to 576-delete-contributors-githubusers-endpoint April 14, 2023 21:57
@github-actions github-actions bot added mobile Mobile related changes ( mobile folder ) models models package labels Apr 15, 2023
Base automatically changed from 576-delete-contributors-githubusers-endpoint to main April 15, 2023 11:05
@github-actions github-actions bot added the feature Feature label Apr 15, 2023
@ZibanPirate ZibanPirate marked this pull request as ready for review April 15, 2023 11:31
@ZibanPirate ZibanPirate requested a review from a team April 15, 2023 11:31
@ZibanPirate ZibanPirate added this to the migrate ./data to ./api milestone Apr 15, 2023
omdxp
omdxp approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@ZibanPirate ZibanPirate merged commit 41f2576 into main Apr 15, 2023
@ZibanPirate ZibanPirate deleted the 578-remove-old-interfacestypesentities branch April 15, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees

@ZibanPirate ZibanPirate

Labels
api API related changes ( api folder ) data Data related changes ( data folder ) feature Feature mobile Mobile related changes ( mobile folder ) models models package tooling tooling package ui ui package web Web related changes ( web folder )
Projects
DzCode i/o
Status: Merged
Milestone
migrate ./data to ./api
Development

Successfully merging this pull request may close these issues.

remove old interfaces/types/entities
2 participants
@ZibanPirate @omdxp