Skip to content

Commit

Permalink
Clarify comment for default choice of https
Browse files Browse the repository at this point in the history
  • Loading branch information
ePirat committed Apr 10, 2022
1 parent 87af7bf commit 8a427d9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/credhelper/credhelper.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ func NewGitLabCredentialsHelper() credentials.Helper {
}

func parseRegistryURL(urlString string) (*url.URL, error) {
// If no scheme is given, assume https to we can properly parse
// If no scheme is given, use https as it is the default
// for docker registries
if !(strings.HasPrefix(urlString, "https://") ||
strings.HasPrefix(urlString, "http://")) {
urlString = "https://" + urlString
Expand Down

0 comments on commit 8a427d9

Please sign in to comment.