Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21357] Remove TopicAttributes from public APIs and make it private in xmlparser #100

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 20, 2024

Description

This PR makes the Discovery Server to keep track of the xml topic profiles instead of asking the rtps_participant for them.
It correlates with the implementation PR: eProsima/Fast-DDS#5085

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • NO Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 26, 2024 08:10
@MiguelCompany MiguelCompany merged commit 40d8c97 into master Jul 26, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/21357 branch July 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants