Review #3
Review #3
Conversation
| @@ -1,4 +1,4 @@ | |||
| # Pragmatic Vue Components 🔌 | |||
| # Pragmatic Vue Components | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -13,19 +13,16 @@ const componentRegistry = { | |||
|
|
|||
| module.exports = function (eleventyConfig) { | |||
| eleventyConfig.addPassthroughCopy({ public: '/' }); | |||
| eleventyConfig.addPassthroughCopy('components'); | |||
| // eleventyConfig.addPassthroughCopy('components'); | |||
|
|
|||
| eleventyConfig.addPassthroughCopy('node_modules'); | |||
|
|
|||
| eleventyConfig.on( | |||
| 'eleventy.after', | |||
| async ({ dir, results, runMode, outputMode }) => { | |||
There was a problem hiding this comment.
Is this a good change?
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Not a great change...
|
top level comment |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
How about this?
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
another comment.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
one more try here...
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Keep making comms
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
how
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
asgga
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
sgdsag
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
saljhklsahg
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Here is a comment for you
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Another nice comment.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Feedback is great.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Another Comment Here
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions
|
@prcl8tr wgat yo |
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved
.eleventy.js line 22 at r2 (raw file):
Previously, earlAchromatic (Jacob Milhorn) wrote…
Not a great change...
???
ultimately
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @earlAchromatic)
Dummy commit for reviewable app
This change is