Test branch #4

earlAchromatic · 2022-05-10T16:29:10Z

This change is

earlAchromatic

Add a Comment here

Reviewable status: 0 of 6 files reviewed, all discussions resolved

earlAchromatic

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

.eleventy.js line 16 at r1 (raw file):

module.exports = function (eleventyConfig) {
  eleventyConfig.addPassthroughCopy({ public: '/' });

sdgd

earlAchromatic

sf

Reviewed all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions

.eleventy.js line 15 at r1 (raw file):

};

module.exports = function (eleventyConfig) {

eleventyConfig.addPassthroughCopy({ public: '/' });
// eleventyConfig.addPassthroughCopy('components');

.eleventy.js line 36 at r1 (raw file):

  });

  return {

return {
dir: {

src/page.html line 11 at r1 (raw file):

      <p>Some text here</p>
      <myHeader :prop="{{prop}}">{{Header}}</myHeader>
    </div>

sdfsdf

earlAchromatic

To do is done

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

lorep ispum

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Some clever comment here

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

here comment is ready

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

See if this flashes here

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

See if it flashes now

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

How about now?

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

WIth overflow set to none?

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

How about scrolled down the page?

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Test it now

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

On large screen

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Keep adding comments

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Keep adding comments

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Keep adding comments

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

adding comments

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

why does it scroll

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

why does it scroll?

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

Why does it scrolL?

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

asdf

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

asdf

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

asdf

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic

asdf

Reviewable status: all files reviewed, 3 unresolved discussions

earlAchromatic · 2022-10-05T01:27:38Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dsf

sg

earlAchromatic · 2022-10-05T01:32:51Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sg

dg

earlAchromatic · 2022-10-05T01:36:41Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dg

hd

earlAchromatic · 2022-10-05T01:38:25Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

hd

hs

earlAchromatic · 2022-10-05T01:40:23Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

hs

adsg

earlAchromatic · 2022-10-05T01:46:45Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

adsg

dsh

earlAchromatic · 2022-10-05T01:46:50Z

.eleventy.js line 11 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dsh

ahh

earlAchromatic · 2022-10-05T01:47:27Z

.eleventy.js line 9 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

gaas

ah

earlAchromatic · 2022-10-05T02:56:09Z

-- commits line 31 at r8:

Previously, earlAchromatic (Jacob Milhorn) wrote…

sf

sdfsdfsd

Code quote (i):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (ii):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (iii):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (iv):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (v):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (vi):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (vii):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (viii):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (ix):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (x):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (xi):

New commits in r7 on 7/25/2022 at 10:39 PM:

Code quote (xii):

New commits in r7 on 7/25/2022 at 10:39 PM:

earlAchromatic · 2022-10-05T21:06:03Z

-- commits line 22 at r8:
dafg

earlAchromatic · 2022-10-05T21:06:09Z

-- commits line 22 at r8:
dfs

Code quote:

- 99d707d: refactor: move index and page to src dir

- fdbb894: review changes

- d8280e7: fix: minor edits

New commits in r2 on 6/6/2022 at 8:23 PM:
- f9fc52a: no eol test A

New commits in r3 on 6/7/2022 at 10:09 PM:
- cbc4776: long line

New commits in r4 on 7/12/2022 at 2:05 PM:
- eef1fdc: add end of file newline in footer

New commits in r5 on 7/14/2022 at 5:19 PM:

earlAchromatic · 2022-10-05T21:06:17Z

Previously, earlAchromatic (Jacob Milhorn) wrote…

kh

sag

earlAchromatic · 2022-10-05T21:06:26Z

.eleventy.js line 6 at r8 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sdf

dfs

Suggestion (i):

const util = require(' futil');

Code quote (ii):

const util = require('futil');

Suggestion (iii):

const util = require('futconst jsdom = require('jsdom');

const util = require('util');
const util = require('futil');
il');const util = require('fuconst viteConfig = require('./vite.config.js');
const jsdom = require('jsdom');
const { JSDOM } = jsdom;
const util = require('util');
til');

Code quote (iv):

const util = require('futil');

Code quote (v):

const util = require('futil');

Code quote (vi):

const util = require('futil');

Code quote (vii):

const viteConfig = require('./vite.config.js');
const jsdom = require('jsdom');

const util = require('util');
const util = require('futil');

earlAchromatic · 2022-10-08T02:26:25Z

vite.config.js line 8 at r5 (raw file):

  plugins: [vue()],
  clearScreen: false,
  server: {

Suggestion:

  server: {sadgkljsdfklhklhflkjsalkfjklasjdfkljaslkjflkjalskdjflkjalskjdlkfjalskjdflkjsaldfjlkasjdflkjsalkdfjlkasjdflkjaslkdfjklasjdflkjaslkdjfklasjdflkjsalkdjflkajsdflkjsalkjdf

earlAchromatic · 2022-10-12T02:32:50Z

.eleventy.js line 6 at r8 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dfs

sgsdfsfd

fasd

sagd

sg

sdf

sf

sg

sdfsdf

sdf sdf

sfs

a
sg

sg

sf

Suggestion (i):

const EleventyVitePlugin = require('@11ty/eleventy-plugin-vite');
const viteConfig = require('./vite.config.js');
const jsdom = requisdfre('jsdom');


const util = require('util');
const util = require('fsutil');

Code snippet (ii):

ssggsdgf

Code snippet (iii):

  sdgasdlkasjdfklasjdlkfjaskldfjklasjdfklajsdklfjaklsjdflkasjdklfjaklsjdfklajskdlfjaslkjdfklasjdklfjaskljdflkajsdlkfjaskldjflksajdlfjasldkf

earlAchromatic · 2023-03-22T19:07:43Z

@oscl8tr

earlAchromatic · 2023-05-02T01:22:49Z

.eleventy.js line 33 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

fx

code

earlAchromatic · 2023-05-02T01:30:54Z

.eleventy.js line 16 at r4 (raw file):

Heading 1

Heading 2

Heading 3

Heading 4

Heading 5

Heading 6

Bullet point
- Sub-bullet point
  - Sub-sub-bullet point

Ordered list item
Another ordered list item
Yet another ordered list item

This is a paragraph.

This is a blockquote.

This is inline code.

This is a code block.

Column 1	Column 2
Row 1, Column 1	Row 1, Column 2
Row 2, Column 1	Row 2, Column 2

Bold text

Italicized text

~~Strikethrough text~~

Link text

earlAchromatic · 2023-05-02T23:25:45Z

.eleventy.js line 17 at r5 (raw file):

eleventyConfig) {eleventyConfig.addPassthroughCopy('components');eleventyConfig.addPassthroughCopy('node_meleventyConfig.addPassthroughCopy('components');eleventyConfig.addPassthroughCopy('node_m

earlAchromatic · 2023-05-02T23:32:50Z

.eleventy.js line 16 at r4 (raw file):

Heading 1

Heading 2

Heading 3

Heading 4

Heading 5

Heading 6

Bullet point

Sub-bullet point

Sub-sub-bullet point

Ordered list item

Another ordered list item

Yet another ordered list item

This is a paragraph.

This is a blockquote.

This is inline code.
This is a code block.
Column 1 Column 2

Row 1, Column 1 Row 1, Column 2

Row 2, Column 1 Row 2, Column 2

Bold text

Italicized text

~~Strikethrough text~~

Link text

earlAchromatic · 2023-06-07T00:47:34Z

.eleventy.js line 18 at r5 (raw file):

sf

earlAchromatic · 2024-06-19T21:27:41Z

earlAchromatic · 2024-06-19T21:35:03Z

oscl8tr

Reviewed 1 of 4 files at r5.
Reviewable status: 9 of 12 files reviewed, 37 unresolved discussions

oscl8tr

hlk

Reviewable status: 9 of 12 files reviewed, 37 unresolved discussions

earlAchromatic · 2024-07-08T20:18:33Z

-- commits line 20 at r8:
sgdf

Code quote:

New commits in r4 on 7/12/2022 at 2:05 PM:
- eef1fdc: add end of file newline in footer

earlAchromatic · 2024-07-08T20:18:48Z

-- commits line 22 at r8:

Previously, earlAchromatic (Jacob Milhorn) wrote…

dafg

Code snippet (i):

<time/> is a mystery </ss?>

<div>

Code quote (ii):

New commits in r5 on 7/14/2022 at 5:19 PM:

earlAchromatic · 2024-07-08T20:23:39Z

-- commits line 22 at r8:


New commits in r2 on 6/6/2022 at 8:23 PM:
- f9fc52a: no eol test A

earlAchromatic

https://reviewable.io/lgtm.png

https://reviewable.io/lgtm.png

https://reviewable.io/lgtm.png

https://reviewable.io/lgtm.png

Reviewed 1 of 6 files at r1, all commit messages.
Reviewable status: 10 of 12 files reviewed, 60 unresolved discussions (waiting on @oscl8tr)

a discussion (no related file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sag

___ *[`-- commits` line 24 at r8](http://localhost:8080/reviews/earlAchromatic/11ty-vue-pragmatic-components/4#-N9m86Vt3DBLIl370paV:-NUPLdLB9ImeCBzR9BAn:b-sqyskd):* > ``` > b287869: remove some things to test elid > ```

- b287869: remove some things to test elide

emove some t

-- commits line 31 at r8:

sdfsdfsd

mits in r7 on 7/25/20

.eleventy.js line 17 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sdf

sdf

Code quote:

    async ({ dir, results, runMode, outputMode }) => {

.eleventy.js line 19 at r3 (raw file):

// This is some text t//

.eleventy.js line 25 at r3 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dfds

dsf

Code snippet:

sdfsdf

.eleventy.js line 33 at r3 (raw file):

code

.eleventy.js line 11 at r5 (raw file):

nts/myHeader.vue',

  myFooter: '../components/myFoote

myHeader: '../components/myHeader.vue',

  myFooter: '../components/myFooter.

.eleventy.js line 17 at r5 (raw file):

  _findOppositeSchemes(scheme) {
    if (_.has(EXCLUSIVE_COLOR_SCHEME_MAP, scheme)) {
      const result = EXCLUSIVE_COLOR_SCHEME_MAP[scheme];
      return _.isArray(result) ? result : [result];
    }
    const result = _.findKey(EXCLUSIVE_COLOR_SCHEME_MAP, colorScheme => {
      return _.isArray(colorScheme) ? _.includes(colorScheme, scheme) : colorScheme === scheme;
    });
    return result ? [result] : [];
  }sd

> yConfig) {eleventyConfig.a
> ```

# Heading 1

## Heading 2

### Heading 3

### Heading 4

### Heading 5

### Heading 6

.eleventy.js line 17 at r6 (raw file):

  eleventyConfig.addPassthroughCopy('components');

  eleventyConfig.addPassthroughCopy('node_modules');

.eleventy.js line 21 at r6 (raw file):

y.after',
    async ({ d

    'eleventy.asfter',

    async ({ dir, ressults, runMode, outputMode }) => {

.eleventy.js line 6 at r8 (raw file):

dfs

const util = require(' futil');

.eleventy.js line 11 at r8 (raw file):

dfs

vite.config.js line 6 at r5 (raw file):

efault defineConfig({


  plugins

vite.config.js line 16 at r6 (raw file):

solve: {
},

build: {
mode: 'production',

-- commits line 22 at r8:
sdfdssdfsdf

src/page.html line 5 at r8 (raw file):

prop: '125'
---

My thought is that what if you did it differently?

.eleventy.js line 1 at r2 (raw file):

const EleventyVitePlugin = require('@11ty/eleventy-plugin-vite');

console.log(markdown, ev.clipboardData.getData('text/markdown'));

.eleventy.js line 4 at r2 (raw file):

const viteConfig = require('./vite.config.js');
const jsdom = require('jsdom');
const { JSDOM } = jsdom;

sdf

.eleventy.js line 60 at r2 (raw file):

    if (!comp) {
      continue;
    }

sdf

.eleventy.js line 93 at r2 (raw file):

    el.setAttribute('injectionPoint', true);
    el.innerHTML = VueWrapper;
    comp.replaceWith(el);

sdfsdf

.eleventy.js line 95 at r2 (raw file):

    comp.replaceWith(el);
  }
}

sdfsdf

.eleventy.js line 33 at r3 (raw file):

    dir: {
      input: 'src',
    },

sd

.eleventy.js line 43 at r3 (raw file):

  tryComponents(doc);

  return dom.serialize();

sf

.eleventy.js line 10 at r4 (raw file):

const componentRegistry = {
  myHeader: '../components/myHeader.vue',

sdf

.eleventy.js line 64 at r4 (raw file):

    //check comp recursively against component registry

    //let props = Object.values(comp.attributes);

sdf

.eleventy.js line 70 at r4 (raw file):

<script type=module>
import {createApp} from "../node_modules/vue/dist/vue.esm-bundler.js";
import ${registeredComponent} from "${registeredComponentPath}";

sdf

.eleventy.js line 85 at r4 (raw file):

`;
    let el = doc.createElement('div');
    el.setAttribute('injectionPoint', true);

sdf

.eleventy.js line 88 at r4 (raw file):

    el.innerHTML = VueWrapper;
    comp.replaceWith(el);
  }

sdf

.eleventy.js line 89 at r4 (raw file):

    comp.replaceWith(el);
  }
}

sdfsdf

.eleventy.js line 13 at r8 (raw file):

  myHeader: '../components/myHeader.vue',
  myFooter: '../components/myFooter.vue',
  Loading: '../components/Loading.vue'

sdfHeading 1

.eleventy.js line 52 at r8 (raw file):

    let componentString = '';

    let tempComponentReg = [];

s

.eleventy.js line 70 at r8 (raw file):

  template: \`
  <${registeredComponent}>
  ${childTemplate}

sdf

.eleventy.js line 88 at r2 (raw file):

    comp.replaceWith(el);
  }
}

sdfsdf

.eleventy.js line 88 at r2 (raw file):

    comp.replaceWith(el);
  }
}

sdf

.eleventy.js line 88 at r2 (raw file):

    comp.replaceWith(el);
  }
}

dsf

.eleventy.js line 88 at r2 (raw file):

    comp.replaceWith(el);
  }
}

sdfsdf

.eleventy.js line 88 at r2 (raw file):

    comp.replaceWith(el);
  }
}

sdf

.eleventy.js line 15 at r3 (raw file):

module.exports = function (eleventyConfig) {
  eleventyConfig.addPassthroughCopy({ public: '/' });

sagsdf## Heading 2

Heading 3

Heading 4

Heading 5

Code quote:

module.exports = function (eleventyConfig) {
  eleventyConfig.addPassthroughCopy({ public: '/' });

.eleventy.js line 18 at r5 (raw file):

  eleventyConfig.addPassthroughCopy('components');
  eleventyConfig.addPassthroughCopy('node_modules');

sdf

.eleventy.js line 18 at r5 (raw file):

  eleventyConfig.addPassthroughCopy('components');
  eleventyConfig.addPassthroughCopy('node_modules');

sdfsdf

const a = {my: "string"}

Code snippet:

dfg

.eleventy.js line 20 at r8 (raw file):

  eleventyConfig.on(
    'eleventy.after',

sdf

Code quote:

module.exports = function (eleventyConfig) {

.eleventy.js line 18 at r5 (raw file):

module.exports = function (eleventyConfig) {
  eleventyConfig.addPassthroughCopy({ public: '/' }); eleventyConfig.addPassthroughCopy('components');eleventyConfig.addPassthroughCopy('node_modules');eleventyConfig.on('eleventy.after',
    async ({ dir, results, runMode, outputMode }) => {

sdf

.eleventy.js line 57 at r5 (raw file):

    }

    let childTemplate = comp.innerHTML;

sd

earlAchromatic

Reviewed 1 of 6 files at r1, all commit messages.
Reviewable status: 10 of 12 files reviewed, 60 unresolved discussions (waiting on @oscl8tr)

earlAchromatic added 5 commits April 20, 2022 23:26

chore: remove vite plugin import

26ac82e

doc: update readme to reflect new objectives

799bed0

refactor: move index and page to src dir

99d707d

review changes

fdbb894

fix: minor edits

d8280e7

earlAchromatic commented May 10, 2022

View reviewed changes

earlAchromatic commented May 16, 2022

View reviewed changes

earlAchromatic commented May 23, 2022

View reviewed changes

oscl8tr reviewed Jun 29, 2024

View reviewed changes

earlAchromatic commented Jan 7, 2025

View reviewed changes

Test branch #4

Are you sure you want to change the base?

Test branch #4

Conversation

earlAchromatic commented May 10, 2022 • edited Loading

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic left a comment

Choose a reason for hiding this comment

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 5, 2022

earlAchromatic commented Oct 8, 2022

earlAchromatic commented Oct 12, 2022

earlAchromatic commented Mar 22, 2023

earlAchromatic commented May 2, 2023

earlAchromatic commented May 2, 2023

Heading 1

Heading 2

Heading 3

Heading 4

Heading 5

Heading 6

earlAchromatic commented May 2, 2023

earlAchromatic commented May 10, 2022 •

edited

Loading