Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data files for g-point cloud optics #7

Open
wants to merge 6 commits into
base: feature-gpoint-cloud-optics
Choose a base branch
from

Conversation

mjiacono
Copy link

No description provided.

@RobertPincus
Copy link
Member

@RobertPincus
Copy link
Member

RobertPincus commented Dec 13, 2024

@mjiacono Lest this grow 100% stale, can I ask you to rename files on your side to leave existing files unchanged and provide four new files with optical properties by g-point?

This means existing data doesn't change, while new data gets added.

@RobertPincus RobertPincus changed the base branch from main to develop December 13, 2024 02:32
@mjiacono
Copy link
Author

@RobertPincus I'm not sure where you're looking, but the new cloud optics files already have new names and the old files are unchanged on my fork (https://github.com/mjiacono/rrtmgp-data).

@RobertPincus RobertPincus changed the base branch from develop to main December 13, 2024 20:35
@RobertPincus
Copy link
Member

@mjiacono Looking closer it seems like your repo currently includes both rrtmgp-clouds-lw.nc and rrtmgp-clouds-lw-bnd.nc (ditto for SW). Can you please remove the latter?

@mjiacono
Copy link
Author

@RobertPincus For this code upgrade, the old cloud optics data file names (rrtmgp-clouds-lw.nc and rrtmgp-clouds-sw.nc), the former cloud optics array names in those files, and the Pade coefficient option are no longer supported. The former LUT cloud optics band data are now renamed in the new files (rrtmgp-clouds-lw-bnd.nc and rrtmgp-clouds-sw-bnd.nc). The proper course of action is to remove the two old cloud optics data file names.

@RobertPincus RobertPincus changed the base branch from main to feature-gpoint-cloud-optics January 14, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants