Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preliminary CI #2

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add preliminary CI #2

wants to merge 12 commits into from

Conversation

RobertPincus
Copy link
Member

This PR adds the first round of continuous integration - it ensures that the libraries build with NVHPC 24.7 on Levante/

Addresses the first task of #1.

@RobertPincus RobertPincus marked this pull request as ready for review November 8, 2024 19:11
@RobertPincus RobertPincus requested a review from Chiil November 8, 2024 19:11
Chiil
Chiil reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Chiil Chiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What is your preferred option with the RTE_USE_CBOOL?

@RobertPincus
Copy link
Member Author

@Chiil RTE_USE_CBOOL is needed for gfortran; it basically ensures compatibility with the C bindings for the kernels. Either value is possible as long as the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiil Chiil Chiil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertPincus @Chiil