Format Python with isort and black #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brendancol @tcmetzker @sehnem Comments welcome |
|
@tcmetzger sorry for mis-spelling |
skosukhin
force-pushed
the
ci-format-python
branch
from
406fd80 to
40b3c47
Compare
skosukhin
force-pushed
the
ci-format-python
branch
from
40b3c47 to
66517c1
Compare
|
Superseded by #339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably for the Python team to review:
isortandblack.flake8.pre-commitconfiguration with respective hooks.This should not be merged as is. First, we need to agree on the formatting (e.g. the line length, which is currently set to
black's default88). Then we will need to apply the formatting in a different PR, merge it todevelop, update.git-blame-ignore-revsin this PR accordingly, and only then merge this PR.Depends on #338.