Fixed DbMigration classes (put them in the right place) #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Jun 13, 2023
|
|
||
| It is also important, if new models are added, that all table names (also for M2M) are added in the `DbMigrationTest` | ||
| cleanup routine. | ||
|
|
There was a problem hiding this comment.
Wrote some documentation what is the intention of these tests.
@jonasPoehler FYI
| @@ -1,4 +1,4 @@ | |||
| package misc.migration.v1_0; | |||
| package misc.migration.v1_1; | |||
There was a problem hiding this comment.
The classes form an earlier test exists only in v1_0
As the directories v1_0 and v1_2 should be equal, I decided to move them to v1_1 instead of copying them
| // FIXME: MariaDb produces an invalid quoted statement. We would need to fix quotes here. | ||
| // but using reserved names for tables is a bad idea IMHO | ||
| // actual: update "table" set textfield = '' where textfield is null; | ||
| // expected: update `table` set textfield = '' where textfield is null; |
There was a problem hiding this comment.
This is an open issue. I will not address that in this PR
Maybe it will never get fixed, becase giving a table the name table is a bad idea ;)
| // Note: tablespaces are currently only supported for DB2 | ||
| // to be prepared for future (when we support sql server filegroups), | ||
| // we allow to specify the DB-platform here | ||
| @Tablespace(value = "db2;TSTABLES;", index = "db2;INDEXTS;") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rob-bygrave
This PR fixes some issues in the DbMigration/DbMigrationGenerate tests.
There are no changes in production code. It would be great, if this can be merged with priority, as I would need this for further tests related to #3103