Skip to content

Commit

Permalink
Merge pull request #6041 from manuelmeister/feature/ui-checklists-imp…
Browse files Browse the repository at this point in the history
…rovement

Fix checklist ui bugs
  • Loading branch information
pmattmann authored Sep 29, 2024
2 parents 6233ac9 + 07bbbfe commit b267dc7
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
11 changes: 10 additions & 1 deletion frontend/src/components/activity/content/Checklist.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
v-model="showDialog"
icon="mdi-clipboard-list-outline"
:title="$tc('components.activity.content.checklist.title')"
:cancel-action="close"
:cancel-visible="false"
>
<template #activator="{ on }">
<button
Expand Down Expand Up @@ -42,7 +44,7 @@
>
</template>
</v-list-item-subtitle>
<v-list-item-title>
<v-list-item-title class="ec-checklist--item-title">
{{ parents.map(({ position }) => position + 1 + '.').join('')
}}{{ item.position + 1 }}. {{ item.text }}
</v-list-item-title>
Expand Down Expand Up @@ -257,6 +259,9 @@ export default {
this.uncheckedItems = []
this.dirty = false
},
close() {
this.showDialog = false
},
},
}
</script>
Expand All @@ -267,4 +272,8 @@ export default {
overflow: hidden;
text-overflow: ellipsis;
}
.ec-checklist--item-title {
white-space: normal;
line-height: 1.33;
}
</style>
4 changes: 4 additions & 0 deletions frontend/src/components/checklist/SortableChecklist.vue
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,15 @@ export default {
padding-bottom: 6px;
display: grid;
}
.e-checklist-dragarea--inner {
min-width: 0;
}
.e-checklist-dragarea.dragging:deep(.e-checklist-dragarea) {
background: rgba(0, 130, 236, 0.15);
padding-bottom: 0;
}
.e-sortable-checklist-item__add {
min-width: 0;
padding-top: 2px;
padding-bottom: 2px;
}
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/components/dialog/DialogBottomSheet.vue
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,12 @@ export default {
.error-area:empty {
display: none;
}
:deep(.ec-dialog-form.v-bottom-sheet.v-dialog) {
overflow-y: auto;
}
.ec-dialog-toolbar {
position: sticky;
z-index: 10;
top: 0;
}
</style>

0 comments on commit b267dc7

Please sign in to comment.