Frontend checklist implementation #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
added
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Merged
manuelmeister
changed the title
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Open
fix unittest
manuelmeister
added
deploy!
|
works like a charm, thank you
|
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
reviewed
Sep 12, 2024
frontend/src/components/activity/ButtonNestedContentNodeAdd.vue
Outdated
Show resolved
Hide resolved
BacLuc
reviewed
Sep 12, 2024
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
approved these changes
Sep 12, 2024
simfeld
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
- feature toggle works ✅
- creating and editing checklists ✅
- using checklists in schedule entries ✅
- drag & drop causes backend errors ❌
An exception occurred while executing a query: SQLSTATE[23505]:
Unique violation: 7
ERROR: duplicate key value violates unique constraint "checklistitem_checklistid_parentid_position_unique" DETAIL: Key (checklistid, parentid, "position")=(c5163ea9d9a6, 9d13b06a9080, 2) already exists.
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
Now also displays checklists if more than 1 of them exist 👍 LGTM |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See example: https://bacluc-1.ecamp3.ch/
See feature toggle: https://pr5460.ecamp3.ch/camps/3c79b99ab424/GRGR/program/activities/12f34c89ce11
Frontend part of #4936