use api prod image for e2e tests #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
pmattmann
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
approved these changes
Aug 13, 2024
simfeld
approved these changes
Aug 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Else the api may still be running migrations during the tests.
That we have a more similar setup in development as in prod. Use the same Caddyfile for dev and prod. Issue: ecamp#5277
…uthentication.yaml When we want to run the prod image on localhost, we must use insecure cookies for firefox for our e2e tests.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Because the dev container may stop responding during the e2e tests.
BacLuc
force-pushed
the
use-api-prod-build-for-e2e-tests
branch
from
004f67c to
4c466a1
Compare
BacLuc
commented
Aug 28, 2024
| # This should correspond to the server declared in PHPStorm `Preferences | Languages & Frameworks | PHP | Servers` | ||
| # Then PHPStorm will use the corresponding path mappings | ||
| PHP_IDE_CONFIG: serverName=localhost | ||
| DATABASE_URL: "postgresql://ecamp3:ecamp3@database:5432/ecamp3dev?serverVersion=15&charset=utf8" |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reusable-e2e-tests-run.yml: prepare api before running tests
Else the api may still be running migrations during the tests.
seperate frankenphp from ingress for local development
That we have a more similar setup in development as in prod.
Use the same Caddyfile for dev and prod.
closes #5277
api: allow to use insecure cookies in prod environment in lexik_jwt_authentication.yaml
When we want to run the prod image on localhost,
we must use insecure cookies for firefox for our e2e tests.
reusable-e2e-tests-build.yml: use prod build of the api container
Because the dev container may stop responding during the e2e tests.
Also includes #5558