Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove readme trusted issuer ext #3622

Merged

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

After eclipse-edc/GradlePlugins#192 was merged we can not autodoc partitioned stile configuration and remove the README file

Why it does that

documentation

@wolf4ood wolf4ood changed the title Chore/remove readme trusted issuer ext chore: remove readme trusted issuer ext Nov 16, 2023
@wolf4ood wolf4ood added the documentation Improvements or additions to documentation label Nov 16, 2023
@wolf4ood wolf4ood force-pushed the chore/remove_readme_trusted_issuer_ext branch from adbcf2a to 2ef065f Compare November 16, 2023 15:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab11d89) 71.77% compared to head (f47884f) 71.78%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
+ Coverage   71.77%   71.78%   +0.01%     
==========================================
  Files         909      909              
  Lines       18127    18134       +7     
  Branches     1033     1033              
==========================================
+ Hits        13011    13018       +7     
  Misses       4672     4672              
  Partials      444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the chore/remove_readme_trusted_issuer_ext branch from 2ef065f to f3ca666 Compare November 16, 2023 16:00
@wolf4ood wolf4ood force-pushed the chore/remove_readme_trusted_issuer_ext branch from f3ca666 to 6b98964 Compare November 17, 2023 07:53
@wolf4ood wolf4ood marked this pull request as ready for review November 17, 2023 08:29
Copy link
Contributor

@saschaisele-zf saschaisele-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick, nothing else.

@wolf4ood wolf4ood merged commit f897641 into eclipse-edc:main Nov 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants