-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove TransferProcess
connectorId
#3625
refactor: remove TransferProcess
connectorId
#3625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3625 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 909 909
Lines 18104 18126 +22
Branches 1027 1033 +6
=======================================
+ Hits 12994 13010 +16
- Misses 4666 4672 +6
Partials 444 444 ☔ View full report in Codecov by Sentry. |
extensions/control-plane/store/sql/transfer-process-store-sql/docs/schema.sql
Outdated
Show resolved
Hide resolved
...ane/transfer-spi/src/main/java/org/eclipse/edc/connector/transfer/spi/types/DataRequest.java
Outdated
Show resolved
Hide resolved
...transfer-spi/src/main/java/org/eclipse/edc/connector/transfer/spi/types/TransferRequest.java
Outdated
Show resolved
Hide resolved
…nector-id # Conflicts: # system-tests/management-api/management-api-test-runner/src/test/java/org/eclipse/edc/test/e2e/managementapi/TransferProcessApiEndToEndTest.java
This pull request is stale because it has been open for 7 days with no activity. |
@jimmarino should we wait for your review or could we merge this? |
What this PR changes/adds
Remove connector id from implementation
Deprecate connector id inside api
Why it does that
cleanup
Further notes
This introduces a breaking change by removing the
connector_id
fromedc_data_request
model.All downstream projects need to apply a migration by dropping the
connector_id
column and it's usages.Linked Issue(s)
Closes #3396