Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove TransferProcess connectorId #3625

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

hamidonos
Copy link
Contributor

@hamidonos hamidonos commented Nov 17, 2023

What this PR changes/adds

Remove connector id from implementation
Deprecate connector id inside api

Why it does that

cleanup

Further notes

This introduces a breaking change by removing the connector_id from edc_data_request model.
All downstream projects need to apply a migration by dropping the connector_id column and it's usages.

Linked Issue(s)

Closes #3396

@hamidonos hamidonos added the refactoring Cleaning up code and dependencies label Nov 17, 2023
@hamidonos hamidonos marked this pull request as draft November 17, 2023 13:45
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd99058) 71.77% compared to head (9fc1699) 71.77%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3625   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files         909      909           
  Lines       18104    18126   +22     
  Branches     1027     1033    +6     
=======================================
+ Hits        12994    13010   +16     
- Misses       4666     4672    +6     
  Partials      444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamidonos hamidonos self-assigned this Nov 20, 2023
@hamidonos hamidonos added the breaking-change Will require manual intervention for version update label Nov 20, 2023
@ndr-brt ndr-brt self-requested a review November 20, 2023 12:53
@jimmarino jimmarino self-requested a review November 20, 2023 13:10
…nector-id

# Conflicts:
#	system-tests/management-api/management-api-test-runner/src/test/java/org/eclipse/edc/test/e2e/managementapi/TransferProcessApiEndToEndTest.java
@hamidonos hamidonos marked this pull request as ready for review November 22, 2023 13:39
@hamidonos hamidonos requested a review from ndr-brt November 22, 2023 13:55
@paullatzelsperger paullatzelsperger removed their request for review November 23, 2023 06:36
Copy link

github-actions bot commented Dec 1, 2023

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Dec 1, 2023
@ndr-brt
Copy link
Member

ndr-brt commented Dec 1, 2023

@jimmarino should we wait for your review or could we merge this?

@ndr-brt ndr-brt removed the stale Open for x days with no activity label Dec 1, 2023
@ndr-brt ndr-brt merged commit 924a977 into eclipse-edc:main Dec 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove TransferProcess connectorId
3 participants