Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create distributions from DataFlowManager transfer types #3669

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 29, 2023

What this PR changes/adds

Makes Catalog's Distribution list being built by the knowledge of the DataFlowManager, because that's where the supported transfer types knowledge is stored.

This is the DataFlowController details:

  • the ProviderPush will get the distributions out of the DataPlaneInstances registered on the connector and associate them with the PUSH flow type
  • the ConsumerPull for the moment will only return a single Http-PULL type, in the future it will be able to provide other pull mechanism as well (ref. docs: decision record about Transfer type #3637)

Why it does that

interoperability

Further notes

Linked Issue(s)

Closes #3631

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Nov 29, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cd9dbec) 71.68% compared to head (e71423d) 71.69%.

Files Patch % Lines
...ipse/edc/connector/transfer/spi/flow/FlowType.java 0.00% 2 Missing ⚠️
...ector/catalog/CatalogDefaultServicesExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3669      +/-   ##
==========================================
+ Coverage   71.68%   71.69%   +0.01%     
==========================================
  Files         916      916              
  Lines       18416    18425       +9     
  Branches     1043     1043              
==========================================
+ Hits        13201    13210       +9     
  Misses       4757     4757              
  Partials      458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ndr-brt ndr-brt merged commit 0266575 into eclipse-edc:main Dec 1, 2023
19 of 21 checks passed
@ndr-brt ndr-brt deleted the 3631-distributions-from-data-flow-manager branch December 1, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use DataFlowManager to create Distribution list
4 participants