Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add context handling capabilities to TypeTransformerRegistry #3965

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Mar 6, 2024

What this PR changes/adds

Provide context handling capabilities to TypeTransformerRegistry, so that context specific transformers will be registered on the specific context (there could be different way to serdes model classes depending on the context: management/dsp/signaling and so on...)

Why it does that

prepare for #3841

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Preparatory refactoring for #3841

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Mar 6, 2024
@ndr-brt ndr-brt requested a review from wolf4ood March 6, 2024 10:37
@ndr-brt ndr-brt force-pushed the 3841-transformer-type-context branch from 7275bf7 to 86dfc16 Compare March 6, 2024 10:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.77193% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 18.05%. Comparing base (7f20ba5) to head (86dfc16).
Report is 122 commits behind head on main.

Files Patch % Lines
...dc/core/transform/TypeTransformerRegistryImpl.java 0.00% 9 Missing ⚠️
...ctnegotiation/ContractNegotiationApiExtension.java 0.00% 8 Missing ⚠️
...figuration/SignalingApiConfigurationExtension.java 0.00% 7 Missing ⚠️
...t/transferprocess/TransferProcessApiExtension.java 0.00% 6 Missing ⚠️
...nt/DataPlaneSignalingClientTransformExtension.java 0.00% 5 Missing ⚠️
...iguration/ManagementApiConfigurationExtension.java 0.00% 4 Missing ⚠️
.../dataplane/api/DataPlaneSignalingApiExtension.java 0.00% 3 Missing ⚠️
...nector/api/management/asset/AssetApiExtension.java 0.00% 2 Missing ⚠️
...or/api/management/catalog/CatalogApiExtension.java 0.00% 2 Missing ⚠️
...ntractagreement/ContractAgreementApiExtension.java 0.00% 2 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3965       +/-   ##
===========================================
- Coverage   71.74%   18.05%   -53.70%     
===========================================
  Files         919      957       +38     
  Lines       18457    19266      +809     
  Branches     1037     1088       +51     
===========================================
- Hits        13242     3478     -9764     
- Misses       4756    15699    +10943     
+ Partials      459       89      -370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 3841-transformer-type-context branch 3 times, most recently from 67a5736 to 52c1e47 Compare March 6, 2024 13:01
@ndr-brt ndr-brt force-pushed the 3841-transformer-type-context branch from 52c1e47 to f6bc9b7 Compare March 6, 2024 13:10
@ndr-brt ndr-brt merged commit 2707784 into eclipse-edc:main Mar 7, 2024
17 checks passed
@ndr-brt ndr-brt deleted the 3841-transformer-type-context branch March 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants