Value Types: Replace checking Q type with checking NullRestricted attribute

[a7ehuo]

As mentioned in #17340, NullRestricted attribute is introduced. This issue is created to track all changes required in the JIT to replace checking Q type with checking NullRestricted attribute.

Below is a list of files that currently checks/use Q type.

• 1-7 and 9-11: Being updated in Check NullRestricted attribute #18179
• 8: Not sure how to deal with it at the moment
  • Add isNullRestricted field to TypeLayoutEntry eclipse-omr/omr#7125
  • Update genAconst_init to check NullRestricted attribute #18189
• 12: Simple change of removal once Q type is completely gone

1. addEntryForFieldImpl
   

   openj9/runtime/compiler/env/J9ClassEnv.cpp

   Line 523 in 05fe2be

   isFieldPrimitiveValueType = vm->internalVMFunctions->isNameOrSignatureQtype(signature);

2. TR_ResolvedJ9Method::isFieldQType
   

   openj9/runtime/compiler/env/j9method.cpp

   Line 9325 in 05fe2be

   return vmThread->javaVM->internalVMFunctions->isNameOrSignatureQtype(signature);

3. TR_ResolvedJ9JITServerMethod::isFieldQType
   

   openj9/runtime/compiler/env/j9methodServer.cpp

   Line 1858 in 05fe2be

   return vmThread->javaVM->internalVMFunctions->isNameOrSignatureQtype(utfWrapper);

4. TR_J9ByteCodeIlGenerator::loadInstance
   

   openj9/runtime/compiler/ilgen/Walker.cpp

   Line 4956 in 05fe2be

   else if (owningMethod->isFieldQType(cpIndex))

5. TR_J9ByteCodeIlGenerator::genWithField
   

   openj9/runtime/compiler/ilgen/Walker.cpp

   Line 6204 in 05fe2be

   else if (owningMethod->isFieldQType(fieldCpIndex))

6. TR_J9ByteCodeIlGenerator::storeInstance
   

   openj9/runtime/compiler/ilgen/Walker.cpp

   Line 6982 in 05fe2be

   else if (owningMethod->isFieldQType(cpIndex))

7. TR_J9ByteCodeIlGenerator::storeStatic
   

   openj9/runtime/compiler/ilgen/Walker.cpp

   Line 7277 in 05fe2be

   else if (owningMethod->isFieldQType(cpIndex))

8. TR_J9ByteCodeIlGenerator::genAconst_init
   

   openj9/runtime/compiler/ilgen/Walker.cpp

   Line 6594 in 05fe2be

   else if (fieldSignature[0] == 'Q')

9. J9::ClassEnv::isClassRefPrimitiveValueType
   

   openj9/runtime/compiler/env/J9ClassEnv.cpp

   Line 1035 in 05fe2be

   return vm->internalVMFunctions->isClassRefQtype(j9class, cpIndex);

10. JITClientCompilationThread.cpp
    

    openj9/runtime/compiler/control/JITClientCompilationThread.cpp

    Line 2063 in 05fe2be

    case MessageType::ClassEnv_isClassRefPrimitiveValueType:

11. MessageTypes.hpp and MessageTypes.cpp
    

    openj9/runtime/compiler/net/MessageTypes.cpp

    Line 210 in 05fe2be

    "ClassEnv_isClassRefPrimitiveValueType",

    
    

    openj9/runtime/compiler/net/MessageTypes.hpp

    Line 223 in 05fe2be

    ClassEnv_isClassRefPrimitiveValueType,

12. A list of files that we can simply remove using Q type from when Q is no longer generated in the signature
    

    openj9/runtime/compiler/env/VMJ9.cpp

    Line 2536 in 05fe2be

    TR::Compiler->om.isQDescriptorForValueTypesSupported() &&

    
    

    openj9/runtime/compiler/env/VMJ9.cpp

    Line 2571 in 05fe2be

    TR::Compiler->om.isQDescriptorForValueTypesSupported() &&

    
    

    openj9/runtime/compiler/env/J9ClassEnv.cpp

    Line 1055 in 05fe2be

    TR::Compiler->om.isQDescriptorForValueTypesSupported() &&

    
    

    openj9/runtime/compiler/runtime/JITClientSession.cpp

    Line 205 in 05fe2be

    TR::Compiler->om.isQDescriptorForValueTypesSupported() &&

[a7ehuo]

@hzongaro fyi