Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update genAconst_init to check NullRestricted attribute #18189

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update genAconst_init to check NullRestricted attribute #18189

merged 1 commit into from
Oct 17, 2023

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Sep 25, 2023 •
edited
Loading

Update genAconst_init to check NullRestricted attribute

Related: #18170

@a7ehuo a7ehuo added comp:jit project:valhalla Used to track Project Valhalla related work labels Sep 25, 2023
@a7ehuo a7ehuo mentioned this pull request Sep 25, 2023
Merged
1 task
@a7ehuo a7ehuo added the depends:omr Pull request is dependent on a corresponding change in OMR label Sep 25, 2023
@a7ehuo a7ehuo mentioned this pull request Sep 25, 2023
Open
3 tasks
@a7ehuo a7ehuo marked this pull request as ready for review September 27, 2023 12:22
@a7ehuo a7ehuo requested a review from hzongaro September 27, 2023 12:25
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Sep 27, 2023

@hzongaro May I ask you to review this change? Thanks!

I'm keeping WIP for now because this PR depends on eclipse-omr/omr#7125. My understanding is that it requires a coordinated merge

hzongaro
hzongaro reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look correct. Just a minor suggestion regarding how flags are queried in different ways.

runtime/compiler/env/J9ClassEnv.cpp Show resolved Hide resolved
@a7ehuo a7ehuo force-pushed the update-genAconst-init branch from 7fcca12 to 8139bfe Compare October 3, 2023 18:07
hzongaro
hzongaro approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hzongaro
Copy link
Member

hzongaro commented Oct 4, 2023

Jenkins test sanity all jdk17 #depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 4, 2023

Jenkins test sanity xlinuxval jdknext depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 5, 2023

JDK 17 ppc64le sanity.functional failures are CRIU-related - issue #17457.

JDKNext x86-64_linux_valhalla build failure is due to issue #18231.

JDK 17 aarch64 mac build failure also seems to be due to issue #18231.

I will wait until we have a fix for #18231 to try running again.

@JasonFengJ9
Copy link
Member

JDKNext x86-64_linux_valhalla build failure is due to issue #18231.

JDKnext_x86-64_linux_valhalla_Nightly passed. The PR build should work now.

@knn-k
Copy link
Contributor

knn-k commented Oct 5, 2023

The aarch64 mac build failure in https://openj9-jenkins.osuosl.org/job/Build_JDK17_aarch64_mac_Personal/499/ will be fixed by PR #18233.

@hzongaro
Copy link
Member

hzongaro commented Oct 8, 2023

Jenkins test sanity all jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 8, 2023

Jenkins test sanity xlinuxval jdknext depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 9, 2023

Looks like there were some infrastructure problems affected testing on some platforms:

ERROR: Cannot resume build because FlowNode 110 for FlowHead 1 could not be loaded.

Jenkins test sanity sanity xmac,aix,plinux,xlinux depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Typo in last PR build attempt.

Jenkins test sanity xmac,aix,plinux,xlinux depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

SIgh! Forgot to include the jdk version:

Jenkins test sanity xmac,aix,plinux,xlinux jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Looks like infrastructure and CRIU failures. Once more:

Jenkins test sanity plinux,xlinux jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

The pcc64le_linux failures are due to #14594. I won't bother rerunning those again.

The x86-64_linux failure looks to be an infrastructure issue. Reruning.

Jenkins test sanity plinux,xlinux jdk17 depends eclipse-omr/omr#7125

@a7ehuo a7ehuo changed the title WIP: Update genAconst_init to check NullRestricted attribute Update genAconst_init to check NullRestricted attribute Oct 13, 2023
@hzongaro
Copy link
Member

Redoing testing in preparation for coordinated merge:

Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 14, 2023 •
edited
Loading

JDK 21 aix and JDK 21 xmac build failures appear to be infrastructure-related. Restarting.

plinux JDK 8 sanity.functional failure appears to be infrastructure-related. Restarting.

plinux sanity.functional failures for JDK 11, JDK 17 and JDK 21 in CRIU tests appear to be due to #17457.

xlinux sanity.functional failures for JDK 8, JDK 11, JDK 17 and JDK 21 all appear to be infrastructure-related. Restarting.

xmac JDK 17 sanity functional test failure appears to be infrastructure-related. Restarting.

plinux sanity.openjdk failures for JDK 8, JDK 11, JDK 17 all appear to be infrastructure-related. Restarting.

plinux JDK 21 sanity.openjdk test failure in jdk_foreign_0 appears to be due to #18074.

xlinux sanity.openjdk test failure for JDK 8, JDK 11 and JDK 17 all appear to be infrastructure-related. Restarting.

xmac JDK 8 sanity.openjdk failures appears to be infrastructure-related. Restarting.

amac sanity.openjdk failures for JDK 17 and JDK 21 appear to be infrastructure-related. Restarting.

Other tests still pending.

@hzongaro
Copy link
Member

Jenkins test sanity.functional,sanity.openjdk xmac,aix jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional plinux jdk8 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional xlinux jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional xmac jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk plinux jdk8,jdk11,jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xlinux jdk8,jdk11,jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xmac jdk8 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk amac jdk17,jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

hzongaro commented Oct 15, 2023 •
edited
Loading

Built these tables with the latest results. Rerunning testing that failed due to infrastructure issues.

Updated 2023-10-15

Updated again 2023-10-16: Only remaining failures are known issues

sanity.functional

JDK 8 JDK 11 JDK 17 JDK 21
alinux ✓ ✓ ✓ ✓
amac N/A ✓ ✓ ✓
aix ✓ ✓ ✓ ✓
plinux ✗ Infrastructure
✓ Passed in rerunning		 ✓ CRIU failures #17457 ✗ Infrastructure
✓ CRIU failures in rerunning #17457		 ✓ CRIU failures #17457
xlinux ✓ ✗ Infrastructure
✓ Passed in rerunning		 ✓ ✓
xmac ✓ ✓ ✗ Infrastructure
✓ Passed in rerunning		 ✗ Infrastructure
✓ Passed in rerunning
xwin 32-bit ✓ and 64-bit ✓ ✗ Infrastructure
✗ Infrastructure failure in rerunning
✓ Passed in rerunning		 ✗ Infrastructure
✗ Infrastructure failure in rerunning
✓ Passed in rerunning		 ✓
zlinux ✓ ✓ ✓ ✓

sanity.openjdk

JDK 8 JDK 11 JDK 17 JDK 21
alinux ✓ ✓ ✓ ✓
amac N/A ✓ ✓ ✗ Infrastructure
✓ Passed in rerunning
aix ✓ ✓ ✓ ✓
plinux ✓ ✗ Infrastructure
✓ Passed in rerunning		 ✗ Infrastructure
✓ Passed in rerunning		 ✓ jdk_foreign_0 failure #18074
xlinux ✗ Infrastructure
✗ Infrastructure failure in rerunning
✓ Passed in rerunning		 ✗ Infrastructure
✓ Passed in rerunning		 ✗ Infrastructure
✓ Passed in rerunning		 ✗ Infrastructure
✓ Passed in rerunning
xmac ✓ ✓ ✓ ✗ Infrastructure
✓ Passed in rerunning
xwin 32-bit ✓ and 64-bit ✓ ✗ Infrastructure
✗ Infrastructure failure in rerunning
✓ Passed in rerunning		 ✓ ✓
zlinux ✓ ✓ ✓ ✓

@hzongaro
Copy link
Member

Jenkins test sanity.functional plinux jdk8,jdk17 depends eclipse-omr/omr#7125
Jenkins test sanity.functional xlinux jdk11 depends eclipse-omr/omr#7125
Jenkins test sanity.functional xmac jdk17,jdk21 depends eclipse-omr/omr#7125
Jenkins test sanity.functional win jdk11,jdk17 depends eclipse-omr/omr#7125

Jenkins test sanity.openjdk amac,xmac jdk21 depends eclipse-omr/omr#7125
Jenkins test sanity.openjdk plinux jdk11,jdk17 depends eclipse-omr/omr#7125
Jenkins test sanity.openjdk xlinux jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7125
Jenkins test sanity.openjdk win jdk11 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional xlinux jdk11 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional xmac jdk17,jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional win jdk11,jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk amac,xmac jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk plinux jdk11,jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xlinux jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk win jdk11 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xlinux jdk8 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional,sanity.openjdk win jdk11 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Jenkins test sanity.functional win jdk17 depends eclipse-omr/omr#7125

@hzongaro
Copy link
Member

Tests passing; only failures are known failures as indicated in comment above.

@hzongaro hzongaro self-assigned this Oct 17, 2023
@hzongaro hzongaro merged commit b965447 into eclipse-openj9:master Oct 17, 2023
@a7ehuo a7ehuo deleted the update-genAconst-init branch March 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

Assignees

@hzongaro hzongaro

Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7ehuo @hzongaro @JasonFengJ9 @knn-k