Update z/TPF code cache strategy #17555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xdaryl pls help find a reviewer for this. |
|
If it makes it easier, all the updates are within z/TPF guard macros and have been running for 2 years. |
|
@0xdaryl Much appreciated. |
|
Jenkins test sanity xlinux jdk17 Changes are guarded with ifdefs that OpenJ9 testing does not enable so light sanity testing seems sufficient. |
|
@mpirvu : this PR introduces changes to the zTPF code cache allocation that are all guarded behind zTPF ifdefs. In spite of that, do you have any comments you want to make prior to merging? |
mpirvu
reviewed
Jul 10, 2023
jjohnst-us
force-pushed
the
zTPFJITconfigUpdate
branch
from
676be9a to
be9f349
Compare
|
@mpirvu : if you approve, I'll launch some light testing on this. |
mpirvu
reviewed
Oct 20, 2023
jjohnst-us
force-pushed
the
zTPFJITconfigUpdate
branch
from
be9f349 to
08f0fe0
Compare
jjohnst-us
force-pushed
the
zTPFJITconfigUpdate
branch
from
08f0fe0 to
25dde4c
Compare
|
Jenkins test sanity zlinux jdk17 |
0xdaryl
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request represents z/TPF OS platform specific updates to code cache strategy.
z/TPF has a second 64-bit heap region managed by the mmap function which allows Java processes to work better with traditional non-java applications. The update enables processes to detect whether the feature is enabled and to allocate the JIT code cache from it based on a heuristic meaningful only to z/TPF. The fallback is to use the other pre-existing 64-bit heap reagion limited by a MAXXMMES system heap configuration unique to the z/TPF platform.