Skip methods with JvmtiMountTransition annotation #18016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
skip_JvmtiMountTransition
branch
from
a2554dd to
48b5b62
Compare
Java methods tagged with the JvmtiMountTransition annotation are involved in transitioning between carrier to virtual threads, and vice-versa. These methods are not part of the thread's scope. So, they should be skipped during introspection by all the relevant JVMTI functions. This commit covers the remaining JVMTI functions which need to skip methods tagged with the JvmtiMountTransition annotation. Fixes: eclipse-openj9#17520 Signed-off-by: Babneet Singh <[email protected]>
babsingh
force-pushed
the
skip_JvmtiMountTransition
branch
from
48b5b62 to
7e12846
Compare
|
This PR addresses the concerns from #17855 (comment). |
|
My personal build with sanity.functional, sanity.openjdk and extended.openjdk test suites across JDK11 and JDK21 looks good: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/17885. Only noticed one known failure, which is reported in #17672. |
|
@gacholio Requesting your review. |
|
jenkins compile win jdk8,jdk21 |
|
jenkins test sanity zlinux jdk21 |
Infra jenkins test sanity zlinux jdk21 |
gacholio
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java methods tagged with the JvmtiMountTransition annotation are
involved in transitioning between carrier to virtual threads, and
vice-versa.
These methods are not part of the thread's scope. So, they should be
skipped during introspection by all the relevant JVMTI functions.
This commit covers the remaining JVMTI functions which need to skip
methods tagged with the JvmtiMountTransition annotation.
Fixes: #17520
Signed-off-by: Babneet Singh [email protected]