Parse softmx on CRIU restore side #18242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
reviewed
Oct 10, 2023
|
we will probably need to clone some of the logic in original independentMemoryParameterVerification for restore path too |
I think here our concern would be still if we need a complete memoryParameterTable as we discussed before |
Should be resolved by the newest commit. |
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
amicic
reviewed
Oct 11, 2023
|
please, squash |
Give the user functionality to specify softmx inside an option file for CRIU restore. Note here we separate gcParseReconfigurableArguments() into gcParseSovereignArguments() and gcParseReconfigurableCommandLine() to distinguish SovereignArguments from general command line options. Signed-off-by: Frank Kang [email protected]
kangyining
force-pushed
the
gcParseRestoreSoftmx
branch
from
6db8901 to
81c5926
Compare
dmitripivkine
approved these changes
Oct 16, 2023
|
jenkins test sanity win, aix jdk17 |
|
jenkins test sanity win,aix jdk17 |
amicic
approved these changes
Oct 16, 2023
|
jenkins test sanity xlinuxcriu jdk17 |
|
seems like special xlinuxcriu build does not exist anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the user functionality to specify softmx inside an option file for CRIU restore.
Note here we separate gcParseReconfigurableArguments() into gcParseSovereignArguments() and gcParseReconfigurableCommandLine() to distinguish SovereignArguments from general command line options.
Signed-off-by: Frank Kang [email protected]