Insert Null value check if array component type is unknown during compilation time #18259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
added
comp:jit
project:valhalla
|
@hzongaro May I ask you to review this change? Thank you! |
hzongaro
reviewed
Oct 10, 2023
…pilation time If the value being stored is NULL and the destination array component is null restricted in runtime, a NPE is expected to throw. Therefore, when the array component type is not known to be identity type in compilation time, a NULLCHK on store value is required. Also add two test cases to test storing NULL into null restricted array, and update the class name in the tests to primitive class to reflect more accurately the type of the class. Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
fix-store-null-arrayelement
branch
from
69f5bd9 to
e050899
Compare
a7ehuo
changed the title
|
Jenkins test sanity all jdk17 |
|
Jenkins test sanity xlinuxval,xlinuxvalst jdknext |
|
xlinux Valhalla sanity.functional testing and xlinux VT Standard sanity.functional testing appear to have failed due to infrastructure issues. Restarting. Jenkins test sanity xlinuxval,xlinuxvalst jdknext |
|
sanity.functional testing for aarch64 macOS, Power Linux, x86 Linux, x86 macOS and Windows all appear to have failed due to infrastructure issues. Restarting. Jenkins test sanity amac,plinux,xlinux,xmac,win jdk17 |
|
openjdknext_j9_sanity.functional_x86-64_linux_vt_standard failed: Looks to be issue #18183 openjdk17_j9_sanity.functional_ppc64le_linux failed failed |
|
Only failures are due to known problem. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value being stored is NULL and the destination array component is null restricted in runtime, a NPE is expected
to throw. Therefore, when the array component type is not known to be identity type in compilation time, a NULLCHK
on store value is required.
Also add two test cases to test storing NULL into null restricted array, and update the class name in the tests to primitive class to reflect more accurately the type of the class.