-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up GC_Finalizable*Buffer classes code #20459
Conversation
fixes #20458 |
do we care about spaces after the comma (I think most of the time we have them)?
|
yes, good point. I am going to fix it. |
Use correct types, fix formatting Signed-off-by: Dmitri Pivkine <[email protected]>
fixed |
jenkins compile aix jdk17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GC_FinalizableClassLoaderBuffer(MM_GCExtensions *extensions) : | ||
_head(NULL) | ||
,_tail(NULL) | ||
,_count(0) | ||
,_extensions(extensions) | ||
, _tail(NULL) | ||
, _count(0) | ||
, _extensions(extensions) | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pattern is an improvement: it reads better, additions or removals (at the end) don't change any other lines, but I suggest the first field should line up with the rest by moving the colon:
GC_FinalizableClassLoaderBuffer(MM_GCExtensions *extensions)
: _head(NULL)
, _tail(NULL)
, _count(0)
, _extensions(extensions)
{}
Use correct types, fix formatting