Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GC_Finalizable*Buffer classes code #20459

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

dmitripivkine
Copy link
Contributor

Use correct types, fix formatting

@dmitripivkine
Copy link
Contributor Author

fixes #20458

@amicic
Copy link
Contributor

amicic commented Oct 31, 2024

do we care about spaces after the comma (I think most of the time we have them)?

	GC_FinalizableReferenceBuffer(MM_GCExtensions *extensions) :
		_head(NULL)
		,_tail(NULL)
		,_count(0)
		,_extensions(extensions)

@dmitripivkine
Copy link
Contributor Author

yes, good point. I am going to fix it.

Use correct types, fix formatting

Signed-off-by: Dmitri Pivkine <[email protected]>
@dmitripivkine
Copy link
Contributor Author

fixed

@amicic
Copy link
Contributor

amicic commented Oct 31, 2024

jenkins compile aix jdk17

Copy link
Contributor

@LinHu2016 LinHu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amicic amicic merged commit dcca4dd into eclipse-openj9:master Oct 31, 2024
4 checks passed
@dmitripivkine dmitripivkine self-assigned this Oct 31, 2024
Comment on lines 89 to 94
GC_FinalizableClassLoaderBuffer(MM_GCExtensions *extensions) :
_head(NULL)
,_tail(NULL)
,_count(0)
,_extensions(extensions)
, _tail(NULL)
, _count(0)
, _extensions(extensions)
{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pattern is an improvement: it reads better, additions or removals (at the end) don't change any other lines, but I suggest the first field should line up with the rest by moving the colon:

	GC_FinalizableClassLoaderBuffer(MM_GCExtensions *extensions)
		: _head(NULL)
		, _tail(NULL)
		, _count(0)
		, _extensions(extensions)
	{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants