Set java.lang.reflect.Field flags for value types #20552
Conversation
theresa-m
added
comp:vm
project:valhalla
|
Also we missed setting flag The title of this PR is "Set java.lang.Field flags for value types", so this can be fix in a separate PR. |
|
Jenkins test sanity.functional,extended.functional alinuxvalst jdknext |
|
Jenkins compile amac jdknext |
|
Jenkins test sanity.functional,extended zlinuxval jdknext |
runtime/oti/j9consts.h
Outdated
| @@ -950,6 +950,12 @@ extern "C" { | |||
| #define PREVIEW_MINOR_VERSION 65535 | |||
| #define J9_IS_CLASSFILE_OR_ROMCLASS_VALUETYPE_VERSION(classfileOrRomClass) (((classfileOrRomClass)->majorVersion >= VALUE_TYPES_MAJOR_VERSION) && (PREVIEW_MINOR_VERSION == (classfileOrRomClass)->minorVersion)) | |||
|
|
|||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | |||
| /* Constants for java.lang.Field flags */ | |||
There was a problem hiding this comment.
this should be java.lang.reflect.Field
|
Link of aarch64_linux_vt_standard build: https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDKnext_aarch64_linux_vt_standard/30/ All other PR builds passed. |
This has been updated. |
hangshao0
changed the title
Commit message needs to be updated as well. |
The value types java.lang.reflect.Field replaces the trustedFinal boolean with a flags int. Set TRUSTED_ACCESS and NULL_RESTRICTED flags. Signed-off-by: Theresa Mammarella <[email protected]>
Updated |
The value types java.lang.reflect.Field replaces the trustedFinal boolean with a flags int. Set TRUSTED_ACCESS and
NULL_RESTRICTED flags.
Fixes: #20372
edit: I ran a personal build to confirm that sanity tests with a valhalla build will pass with this change https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/24974/