Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build break in JDK8,11 due to undefined targetMethodFromMemberName #20582

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Nov 12, 2024

This PR fixes a build break in JDK8 and JDK11 introduced by #20373 which occurred because J9VM_OPT_OPENJDK_METHODHANDLE is not defined.

@dsouzai dsouzai marked this pull request as ready for review November 12, 2024 18:39
@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 12, 2024

jenkins compile xlinux jdk8,jdk11,jdk17

@keithc-ca
Copy link
Contributor

This needs more work; trying to build jdk11:

/home/keithc/space/openj9/jdk11/openj9/runtime/compiler/runtime/SymbolValidationManager.cpp:1591:18: error: 'class TR_J9VM' has no member named 'isInvokeCacheEntryAnArray'
       if (_fej9->isInvokeCacheEntryAnArray(invokeCacheArray))
                  ^~~~~~~~~~~~~~~~~~~~~~~~~

@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 12, 2024

Ok, built both JDK11 and JDK21 manually and both passed, so should be good to go now.

@pshipton
Copy link
Member

jenkins compile zlinux jdk8

@pshipton
Copy link
Member

This build is far enough to confirm no compilation issue with jdk8.

@pshipton pshipton merged commit dd2261e into eclipse-openj9:master Nov 12, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants