Use migrated value classes in Valhalla functional tests #20656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:test
project:valhalla
theresa-m
force-pushed
the
fix_20386
branch
2 times, most recently
from
7f16319 to
2ff20f3
Compare
|
Jenkins test sanity.functional,extended plinuxval jdknext |
Signed-off-by: Theresa Mammarella <[email protected]>
java/lang/Integer was migrated to a value type Signed-off-by: Theresa Mammarella <[email protected]>
Signed-off-by: Theresa Mammarella <[email protected]>
|
The extensions failures should be fixed now. |
hangshao0
reviewed
Nov 28, 2024
test/functional/cmdLineTests/valuetypeddrtests/flattened32bitRefBackfillTest.xml
Show resolved
Hide resolved
These tests are accessing a field of type java.lang.Object that is initialized with the value ValueTypeTests.defaultObject which is an Integer. static Object defaultObject = (Object)0xEEFFEEFF; java.lang.Integer has been migrated to a value class and will not contain a lockword so the expected index has moved. Signed-off-by: Theresa Mammarella <[email protected]>
4 tasks
|
Jenkins test sanity.functional,extended zlinuxval jdknext |
hangshao0
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #20652 #20642
Related: #20386