Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.49) Recognize POWER11 and future coverage on AIX and Linux #20738

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Dec 3, 2024

POWER11 will GA next year. It needs to be recognized now in order to align runtime release with it.

Before OpenJ9 can switch to using OMR's CPU recognition code completely, it is necessary to recognize future POWER processors correctly but as closely as possible for performance purposes before the relevant macro is officially available from AIX system header files. A catch-all macro for future processors is defined as well.

Cherry pick zl-wang@cfce6b2 and remove the unused __power_11 macro.

This will recognize POWER11 in the 0.49 release in advance of a more complicated solution (#20668) that uses OMR instead.

Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typos in the first commit message.

  • furture -> future
  • purpose -> purposes

runtime/port/unix/j9sysinfo.c Outdated Show resolved Hide resolved
runtime/port/unix/j9sysinfo.c Outdated Show resolved Hide resolved
runtime/port/unix/j9sysinfo.c Outdated Show resolved Hide resolved
zl-wang and others added 2 commits December 3, 2024 16:17
POWER11 will GA next year. It needs to be recognized now in order
to align runtime release with it.

Before OpenJ9 can switch to using OMR's CPU recognition code
completely, it is necessary to recognize future POWER processors
correctly but as closely as possible for performance purposes
before the relevant macro is officially available from AIX system
header files. A catch-all macro for future processors is defined
as well.

Signed-off-by: Julian <[email protected]>
@pshipton
Copy link
Member Author

pshipton commented Dec 3, 2024

I think I've addressed all the comments.

@keithc-ca keithc-ca merged commit d06ae14 into eclipse-openj9:v0.49.0-release Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants