Minor VectorAPI boxing fixes #20791
Minor VectorAPI boxing fixes #20791
Conversation
gita-omr
commented
Dec 9, 2024
gita-omr
commented
- do not use TR_enableMaskUnboxing environment option since the issue was fixed
- handle astore correctly when RHS is not aload
- do not use TR_enableMaskUnboxing environment option since the issue was fixed - handle astore correctly when RHS is not aload
|
Removed unneeded |
| TR::DataType elementTypeTmp; | ||
| int32_t bitsLengthTmp; | ||
| vapiObjType objectTypeTmp; | ||
| bool scalarizedTmp; |
There was a problem hiding this comment.
you don't need to initialize these 4 Tmp(s)? and, they are not used after coming back from the call. we experienced a very elusive bug when a call is made with arguments not initialized (although the code was correct): OpenXL optimizer just generated garbage code.
There was a problem hiding this comment.
These are values set by the call and they are not used in this case. Not sure how to make that nicer.
There was a problem hiding this comment.
We do it in other places too. In the future we can return a structure filled in with those values.
There was a problem hiding this comment.
For now, I gave them *Tmp names to make it more obvious.
|
Jenkins test sanity.functional zlinux,plinux,xlinux jdk23 |
gita-omr
added this to the Release 0.49 (Java 8, 11, 17, 21, 23) January refresh milestone
pshipton
removed this from the Release 0.49 (Java 8, 11, 17, 21, 23) January refresh milestone
- do not use TR_enableMaskUnboxing environment option since the issue was fixed - handle astore correctly when RHS is not aload Original PR: eclipse-openj9#20791
