Replace nullptr with NULL in java_lang_invoke_MethodHandleNatives.cpp #20836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Henderson <[email protected]>
|
jenkins test sanity.functional amac jdk17 |
babsingh
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullptrisn't supported on the z/OS XLC v2r1 compiler used for IBM Java 8 builds on s390x.java_lang_invoke_MethodHandleNatives.cppis only compiled in builds with OpenJDK MethodHandles enabled. Once OpenJDK MHs are enabled by default, thenullptrs here would cause build errors on the platform mentioned above. Probably best just to remove thenullptruses now to conform with the supported C++ features list.Signed-off-by: Nathan Henderson [email protected]