Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize the extensionClassLoader from the VM snapshot #20862

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ThanHenderson
Copy link
Contributor

This patch properly initializes the extensionClassLoader on restore runs through the paths in BytecodeInterpreter.hpp and FastJNI_com_ibm_oti_vm_VM.cpp rather than, incorrectly, allocating a new class loader.

Fixes: #20861
Signed-off-by: Nathan Henderson [email protected]

This patch properly initializes the extensionClassLoader on
restore runs through the paths in BytecodeInterpreter.hpp and
FastJNI_com_ibm_oti_vm_VM.cpp rather than, incorrectly, allocating
a new class loader.

Fixes: eclipse-openj9#20861
Signed-off-by: Nathan Henderson <[email protected]>
@babsingh
Copy link
Contributor

jenkins test sanity.functional amac jdk21

@ThanHenderson
Copy link
Contributor Author

The PR build failure is an infra issue.

But all the tests passed from the "failing" build:

17:04:52  TOTAL: 111   EXECUTED: 111   PASSED: 111   FAILED: 0   DISABLED: 0   SKIPPED: 0
17:04:52  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
17:04:52  
17:04:52  ALL TESTS PASSED

@babsingh
Copy link
Contributor

babsingh commented Dec 20, 2024

More details on the failure: Artifiactory was unreachable (infra issue).

17:05:02  Error occurred for request GET /artifactory/api/system/version HTTP/1.1: No route to host (Host unreachable).
17:05:02  Attempting retry #1
17:05:05  Error occurred for request GET /artifactory/api/system/version HTTP/1.1: No route to host (Host unreachable).
17:05:05  Attempting retry #2
17:05:08  Error occurred for request GET /artifactory/api/system/version HTTP/1.1: No route to host (Host unreachable).
17:05:08  Attempting retry #3
17:05:11  Error occurred for request GET /artifactory/api/system/version HTTP/1.1: No route to host (Host unreachable).

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PR build tests passed. No functional test failures were seen.

@babsingh babsingh merged commit 9a1177f into eclipse-openj9:master Dec 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix extensionClassLoader initialization on VM snapshot restore runs
2 participants