Consider the compileMethod() API in replenishInvocationCount() Assertion #20876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpirvu can you have a look at this? |
luke-li-2003
force-pushed
the
CompileMethodAPIFlag
branch
from
7b249a7 to
f27de16
Compare
mpirvu
reviewed
Jan 2, 2025
luke-li-2003
force-pushed
the
CompileMethodAPIFlag
branch
from
f27de16 to
77067cc
Compare
|
Changed the code so that we simply check for |
|
@luke-li-2003 Could you please change the commit message to reflect the new implementation? Thanks |
…rtion replenishInvocationCount will only raise the assertion failure for unexpected count value if the compilation was not set as explicit, since the count value can be any positive integer in that case. Based on eclipse-openj9#15472 Signed-off-by: Luke Li <[email protected]>
luke-li-2003
force-pushed
the
CompileMethodAPIFlag
branch
from
77067cc to
01824c4
Compare
|
jenkins test sanity zlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag in the optimization plan for compilations triggered by the compileMethod API, which can have the invocation count be any positive integer; replenishInvocationCount will not raise the assertion failure for unexpected count value.
Based on #15472
Depends on eclipse-omr/omr#7598