-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valhalla bringup for Java 25 updates #20911
Open
JasonFengJ9
wants to merge
1
commit into
eclipse-openj9:master
Choose a base branch
from
JasonFengJ9:valhalla25
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
added
comp:test
project:valhalla
Used to track Project Valhalla related work
labels
Jan 10, 2025
theresa-m
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VALUE_TYPES_MAJOR_VERSION will also need updating.
theresa-m
reviewed
Jan 10, 2025
test/functional/Valhalla/src/org/openj9/test/lworld/ValhallaUtils.java
Outdated
Show resolved
Hide resolved
Updated -source to 25; Updated VALUE_TYPE_CLASS_FILE_VERSION to 69; Updated VALUE_TYPES_MAJOR_VERSION to 69. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
valhalla25
branch
from
January 10, 2025 21:02
1110a4a
to
9c2f5c2
Compare
JasonFengJ9
changed the title
Valhalla test bringup for Java 25
Valhalla bringup for Java 25 updates
Jan 10, 2025
Fixed. |
theresa-m
approved these changes
Jan 10, 2025
jenkins test sanity.functional alinux64 jdk17 |
Jenkins test sanity,extended xlinuxval jdknext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valhalla bringup for Java 25 updates
Updated
-source
to25
;Updated
VALUE_TYPE_CLASS_FILE_VERSION
to69
;Updated
VALUE_TYPES_MAJOR_VERSION
to69
.This change is required for Valhalla extension Java 25 update
Signed-off-by: Jason Feng [email protected]