feat(Rest) : Advanced Search for project page #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthi-bl
requested review from
heliocastro,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
GMishx
added
needs code review
needs general test
GMishx
requested changes
Dec 23, 2024
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
|
@keerthi-bl please fix the commit message as well. |
keerthi-bl
force-pushed
the
feat/advSearchForProjectRest
branch
2 times, most recently
from
6319c03 to
eb9a778
Compare
keerthi-bl
changed the title
GMishx
requested changes
Dec 24, 2024
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keerthi B L <[email protected]>
keerthi-bl
force-pushed
the
feat/advSearchForProjectRest
branch
from
eb9a778 to
1537205
Compare
GMishx
requested changes
Jan 3, 2025
Comment on lines
302
to
303
| return getProjectResponse(pageable, projectType, group, tag, allDetails, luceneSearch, request, sw360User, | ||
| mapOfProjects, isSearchByName, sw360Projects, isNoFilter); |
There was a problem hiding this comment.
getProjectResponse() no longer requires filter of projectType, group, etc. as it is already done by filterProjectMap() and refineSearch().
|
Created separate issue #2854 . Please fix the changes requested for merging this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Closes : #2832
Description
Rest end point added with following parameters for advance search in a project list page.
Version, Project responsible, State, Clearing State, additional Data.
Suggest Reviewer
How To Test?
URL : http://localhost:8080/resource/api/projects?name=update&version=1.1&state=PHASE_OUT&[email protected]
Response :
{
}
Checklist
Must: