Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable branch protection eclipse-tractusx.github.io main branch #43

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Chore: enable branch protection eclipse-tractusx.github.io main branch #43

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1bf16a
chore: enable branch protection eclipse-tractusx.github.io main branch
FaGru3n Nov 30, 2023
f20f70c
chore: remove reviewer count to use default settings
FaGru3n Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions otterdog/eclipse-tractusx.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ orgs.newOrg('eclipse-tractusx') {
workflows+: {
default_workflow_permissions: "write",
},
branch_protection_rules: [
orgs.newBranchProtectionRule('main') {
dismisses_stale_reviews: true,
required_approving_review_count: 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would highly vote for 1 required approving reviewer. 2 would be very hard for small teams. But maybe we can recommend 2 reviewers (in a TRG?) but enforce 1 reviewer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR is not introduceing branch protection and required review count to the GH Org but to the eclipse-tractusx/eclipse-tractusx.github.io repo only, I would like to require 2 reviewers. For this repository enough stakeholders should be available doing reviews.

Maybe we should also think about to introcude .github/CODEOWNERS (for eclipse-tractusx/eclipse-tractusx.github.io). Code owners are automatically assigned to new PRs:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea of a .github/CODEOWNERS file would be pretty useful. This would also solve the problem of Issues and PRs not associated. We could divide it for every section (like KIT etc.).

},
],
environments: [
orgs.newEnvironment('github-pages') {
branch_policies+: [
Expand Down